search

talalmajali / react-native-countdown-component

React Native CountDown
MIT License
271 stars 234 forks source link

feature: accept timeLabelStyle prop #22

Closed Olcina closed 5 years ago

Olcina commented 5 years ago

Hi,

Thank you for this component.

I wanted to change the label font so I added a timeLabelStyle prop to override the default style for the time labels.

I also add the prop to the table in the README

All the best, Carlos.

Olcina commented 5 years ago

After looking into the Pullrequet #18 opened by @sweetcoco . I added override props for Label and Digits components.

This way we can override all styles for Label and Digits subcomponents.

What do you think @talalmajali?

talalmajali commented 5 years ago

@Olcina Thank you for the pull request, i did a cleanup on label style, digit style, as well as digit txt style, you can check them in this commit 4c81e279df24db9d2f67f2ecbda5fc4563b115a2 please update to v2.0.0 and check the new props style, Thanks 😄

Olcina commented 5 years ago

@talalmajali Thanks for adding those clean-ups (and maintain the props names) updated and running without issues!! :muscle: :rocket: