talamortis / OregonCore

World of Warcraft 2.4.3 Server Emulator
GNU General Public License v2.0
69 stars 51 forks source link

You can interrupt the channel spell, but the script will still execute #157

Open PadreWoW opened 4 years ago

PadreWoW commented 4 years ago

Describe the bug You can interrupt the channel spell, but the script will still execute For example - Quest "The Restless Souls"

To Reproduce Steps to reproduce the behavior:

  1. Take Quest "The Restless Souls"
  2. Use Egan's Blaster and interrupt it's channel spell (jump or move)
  3. You can see - the ghost will still disappear and the fireflies will appear

Branch Master (Last Rev)

Expected behavior Scripts should NOT execute if the channel spell is not completed

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/91782611-you-can-interrupt-the-channel-spell-but-the-script-will-still-execute?utm_campaign=plugin&utm_content=tracker%2F91676571&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F91676571&utm_medium=issues&utm_source=github).
talamortis commented 4 years ago

/could you please give quest Id ect

PadreWoW commented 4 years ago

The Restless Souls - 5282 Inoculation - 9303

All quests/scripts with channeled spells have this problem You can start cast and the interrupt it, but quest/script will still execute

talamortis commented 4 years ago

is this on all channelled spells? even with creatures that are assigned smartAI as i can see in the core that both these quests have a script assigned too them

PadreWoW commented 4 years ago

This problem not only with SAI I did core script for "Inoculation" quest - the same problem

talamortis commented 4 years ago

https://github.com/talamortis/OregonCore/blob/master/src/scripts/EasternKingdoms/Stratholme/stratholme.cpp#L187 - is core

https://github.com/talamortis/OregonCore/blob/master/src/scripts/Kalimdor/azuremyst_isle.cpp#L697 - Is Core

Please check with SAI creatures

PadreWoW commented 4 years ago

ok will check Please tell me on what quest or mob i can check it? I can't remember any quest or mob that needs channeled spell on SAI

talamortis commented 4 years ago

Not 100% sure about this but try https://tbcdb.com/?quest=10808

PadreWoW commented 4 years ago

Unfortunately Staff of Parshah is not channeled spell, just 3 sec cast and shoot