search

talamortis / OregonCore

World of Warcraft 2.4.3 Server Emulator
GNU General Public License v2.0
69 stars 51 forks source link

Ferocious Inspiration Talent Procs Only 1 Time #243

Open PadreWoW opened 3 years ago

PadreWoW commented 3 years ago

Describe the bug Ferocious Inspiration Talent Procs Only 1 Time

To Reproduce Steps to reproduce the behavior:

  1. Create Hunter
  2. Learn Ferocious Inspiration Talent
  3. Attack a Mob with your Pet
  4. Pet should crit and you take 10 sec buff Ferocious Inspiration
  5. On second and other crits there will be no buff

Expected behavior Ferocious Inspiration Talent Should Proc on any pet's critical melee damage and should stack

Branch master

Eluna

HASH/COMMIT: https://github.com/talamortis/OregonCore/commit/731beec089deff8b5a30fc592a003717f2589aac

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/97565736-ferocious-inspiration-talent-procs-only-1-time?utm_campaign=plugin&utm_content=tracker%2F91676571&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F91676571&utm_medium=issues&utm_source=github).
PadreWoW commented 3 years ago

I found interesting thing! Talent procs 2 times! not 1 But after 2 proc pet loses aura 34457 (invisible talent aura) and can not proc again! Aura 34457 SHOULD NOT fall from pet after proc!

talamortis commented 3 years ago

i shall take a look on my next day off work. which is this weekend :)