search

talamortis / OregonCore

World of Warcraft 2.4.3 Server Emulator
GNU General Public License v2.0
69 stars 51 forks source link

Prevent possible stack owerflow in Unit::ProcDamageAndSpellFor Spell 3391 #268

Open PadreWoW opened 2 years ago

PadreWoW commented 2 years ago

Describe the bug Prevent possible stack owerflow in Unit::ProcDamageAndSpellFor Spell 3391

To Reproduce Steps to reproduce the behavior:

  1. Create npc with spell 8876 (Thrash - Adds a chance to do two additional attacks)
  2. Attack him
  3. He will attack you more and more double attacks with error in logs

Expected behavior There should be only 1 extra attack (if one-hand weapon)

Screenshots image

Branch master

HASH/COMMIT: (https://github.com/talamortis/OregonCore/commit/a03262d5fdf9b2e69f0c102e0ab9d741996f5f63)