add tables field to ingest grpc contract

talariadb / talaria

TalariaDB is a distributed, highly available, and low latency time-series database for Presto

MIT License

215 stars 31 forks source link

add tables field to ingest grpc contract #108

Closed jeffreylean closed 2 years ago

jeffreylean commented 2 years ago

Add console writer for debugging purposes
Change ingest_server gRPC contract by adding a new field called tables, in order to support specific table destination(s) while ingesting the batch

atlas-comstock commented 2 years ago

@jeffreylean @kelindar @tardunge Do you think it's a good idea to add a new grpc method instead of breaking the old one? Users(me) may have one table destination in batch, and we don't want to update downstream service.

jeffreylean commented 2 years ago

yes, agreed. This makes much more sense.

tardunge commented 2 years ago

LGTM @atlas-comstock any suggestions?

atlas-comstock commented 2 years ago

LGTM @atlas-comstock any suggestions?

Sure, let me review it today, should be fine

atlas-comstock commented 2 years ago

LGTM

atlas-comstock commented 2 years ago

@tardunge @jeffreylean btw, you are using https://pkg.go.dev/time#Time.UnixMicro which is only supported from 1.17 so that I upgrade the github ci go version.

tardunge commented 2 years ago

I faced a similar issue with UnixNano btwn. Time to bump version to 1.18?

atlas-comstock commented 2 years ago

haha, can. Now it is 1.17. @tardunge