talariadb / talaria

TalariaDB is a distributed, highly available, and low latency time-series database for Presto
MIT License
215 stars 31 forks source link

Make the error message accurate #90

Closed atlas-comstock closed 2 years ago

atlas-comstock commented 2 years ago
2022/05/17 07:22:49 [error] ServerError: target=storage/writer/writer.go.158, reason=Internal Server Error, msg=stream: writer was not configured
2022/05/17 07:22:49 [error] ServerError: target=table/timeseries/timeseries.go.124, reason=Internal Server Error, msg=error reading from uri due to scheme  is not supported

In fact, this behaviour is intended, the table does has not scheme setting and writer configured.

tardunge commented 2 years ago

In my opinion, if the streams are not configured for a table, it should not error out. And it should throw an error if it can't configure any stream which was declared in config.

atlas-comstock commented 2 years ago

@tardunge yeah, agree with you.