search

taleden / EDSY

EDSY is a web-based ship outfitting simulator tool for the game Elite Dangerous
24 stars 7 forks source link

[Enhancement] Inform users about Windows 2083 URL length limit #1

Closed Athanasius closed 4 years ago

Athanasius commented 4 years ago

To aid those users who fail to import a build from EDMC and the like due to hitting the Windows 2083 character limit on URLs under some circumstances I propose.

  1. If the base64 decode step fails
  2. then if the full URL length (including the https://edsy.org/... part) is exactly 2083 characters
  3. then inform the user about the Windows 2083 URL length limit.

NB: I've now realised that perhaps, under some circumstances, EDMC 4.0.x.0 might have an extra issue with this that older, Python 2.7 based, EDMC didn't. I can still open 'long' URLs with Firefox 78.0.2 on Windows 10 without issue though. Either way we'll want to come up with a good set of instructions on how to avoid the issue.

Athanasius commented 4 years ago

See this EDMC issue for some example URLs that hit the limit on one user's Windows 7 machine, despite using Firefox: https://github.com/EDCD/EDMarketConnector/issues/617

taleden commented 4 years ago

Good idea, thanks for the suggestion! This should be added in the next update.

Athanasius commented 4 years ago

Note that we're adding an option to attempt a workaround in 4.0.3 (not yet released):

https://github.com/EDCD/EDMarketConnector/releases/tag/Release%2F4.0.3-rc3

I'll try to remember to update you when that's released so you can include a link to an EDMC Wiki Troubleshooting bit I'll write for it :) .

Athanasius commented 4 years ago

EDMC 4.0.3 is out, and I've documented the option at https://github.com/EDCD/EDMarketConnector/wiki/Troubleshooting#import-failed-no-ship-loadout-found

taleden commented 4 years ago

Finally got around to pushing this out with v3.7.4.1; truncated imports should now generate a warning. Thanks!