search

taleden / EDSY

EDSY is a web-based ship outfitting simulator tool for the game Elite Dangerous
22 stars 7 forks source link

Exporting build with an experimental modification fails #10

Closed Kriper1111 closed 1 year ago

Kriper1111 commented 1 year ago

This happens with any experimental effect on any module. The traceback in console says:

Uncaught TypeError: attribute is undefined
    getExperimentalAttrModifier https://edsy.org/edsy.js:1323
    getEffectiveAttrModifier https://edsy.org/edsy.js:1333
    exportJournal https://edsy.org/edsy.js:1824
    exportJournal https://edsy.org/edsy.js:2868
    exportSLEF https://edsy.org/edsy.js:2891
    showUIExportPopup https://edsy.org/edsy.js:5163
    onUIFitSettingsOpsClick https://edsy.org/edsy.js:9952

And with breakpoints on exceptions enabled, attr value on that line is equal to "name". It somehow tries to get a numeric value of experimental modification's name.. And fails, weirdly enough.

Works as of cb8c30506aa8c08ddc23f907c13fd8ccf9453928 , doesn't happen if https://github.com/taleden/EDSY/blob/cb8c30506aa8c08ddc23f907c13fd8ccf9453928/edsy.js#L1824 is reverted.

taleden commented 1 year ago

Thanks for the report! This should be fixed now in 3.8.14.8.