taleden / EDSY

EDSY is a web-based ship outfitting simulator tool for the game Elite Dangerous
24 stars 7 forks source link

Incorrect module prices #27

Closed ultimatespirit closed 1 week ago

ultimatespirit commented 6 months ago

Hey, I wasn't sure where EDSY pulled its price data from, so apologies if this isn't actually an issue with EDSY / something you can fix.

I noticed that the rebuy price EDSY reported for my imported python ship build was slightly below my actual in game reported rebuy, by a whole 4 credits. Nothing serious but I was curious why so started comparing module prices. Wanted to note down here any inaccuracies I ran into.

I'm guessing these modules got small credit adjustments over the years that never got documented, for why they're slightly off base. This is not an exhaustive list, just one of module classes that happened to be on my ship and available to buy at the station I'm at. Also some of the deviations are off-by-one only which could be rounding issues from the 15% discount display, but I include them anyway.

Rank EDSY (15% discount) Actual (15% discount)
0E 11,518 11,513
0D 34,536 34,539
0B 310,845 310,844
0A 932,535 932,531
Rank EDSY (15% discount) Actual (15% discount)
1E 850 850
2E 2,763 2,763
3E 8,976 8,979
4E 29,181 29,179
5E 94,835 94,832
6E 308,202 308,203
7E 1,001,657 1,001,657
8E 3,255,390 3,255,387

Adjusting for all of the above brought my EDSY purchase price of 89,792,356 down to 89,792,351 with a listed rebuy of 4,489,618 versus the in game rebuy of 4,489,622 (at 5% rebuy rate).

Which still didn't fix the rebuy discrepency so I looked at the ship cost and well...

So... that's a really large amount off, and definitely doesn't solve my rebuy cost calculation issue of not being able to figure out why it's 4 credits off in EDSY, considering an over 1 million discrepency adds way more than 4 credits to your rebuy...

EDIT: Oh, the ship purchase price is probably including all the base parts it comes with that you could sell off doesn't it?

EDIT2: Okay yea, it includes the module costs of the stock build so the EDSY value for the Python hull itself is the remainder after removing those parts. Without 15% discount the stock python is listed with the correct cost of 56,978,180.

With the 15% discount however it sums up to 48,431,458 instead of 453, presumably due to the modules being subtly wrong in price or pointing to an issue with the 15% discount prices. Going through and listing those again...

That works out to 48,431,447, or 6 credits off the in game listed price. Implying the python has a price of 47,018,649 instead of 643.

Which still isn't enough to explain the 4 rebuy cost discrepency...

taleden commented 6 months ago

Way back when E:D Shipyard was first in development (in ... checks notes ... early 2015, wow) I went through several cycles of surveying every single module price in-game, because they seemed to keep changing. Every few weeks, or maybe every patch, they'd fluctuate by +/- 5 credits or something silly, so eventually I gave up and just rounded all the module prices off to the nearest 10 credits and figured it was close enough for practical purposes.

I still don't know if that was a fluke back then that stopped happening eventually, or if it's related to the background economy of the game somehow, or your reputation level with the starport, or what; if you observe that prices for some basket of modules (let's say, one each from weapons, utilities, core components, and optional internals) remains constant across several weeks and at different starports (in different systems, belonging to different superpowers) then I'll be happy to make one more complete run through everything and get them all exactly right. But if they're still fluctuating here and there, then there's no point, it'll be impossible to get them exact down to the credit. :)

ultimatespirit commented 6 months ago

I've been trying really hard, and failing, to play the game instead of turning it on and getting bogged down in documenting random things about it haha. Sounds like I'll have an excuse to periodically look at module costs now. I'm fairly new in the game though so probably won't have much distance spread yet, I'll see what sort of data I can get.

For what it's worth though, with regards to my original thing of trying to figure out why the rebuy cost is off... It seems rebuy costs are just off in general. I purchased an Adder in a 15% discount system for 74,637. The game reports a sale price of 67,173, which is exactly 90% of the purchase price, but a rebuy cost of 3,735, 3-4 above the 5% rebuy value of 3,731.85.

Annoyingly enough, that's not consistent between ships though, it's always 1-4 above what 5% should be but not consistently so. My best guess is some sort of iterative rounding up error arising from internal game math rounding up after every operation, making multiplication non-commutative and adding an "error" per every internal step. That should only really be able to explain a +2 deviation though, I'll need to record values from a non-discounted system sometime to check if discounts are what lead to weird math.

ultimatespirit commented 6 months ago

Okay, seems I've already found some discrepancies. After the Thursday tick / patch it seems some of the modules I had recorded values for and shipping costs for last week have subtly changed in price. At least I don't think I had so many measurement errors in my notes of off by 1 / wrong numbers. One of the modules increased in price by 100 credits by my notes though, so I'm not going to write off my just making a notation error and having typos until I get another week or two of data.

Interestingly enough though if I truly made no errors and they did fluctuate a bit, this would imply that even things already purchased adjust in price as these are the values of my stored modules. Ships seem to have a fixed cost at least so perhaps the interior ship chasis increases/decreases in price internally to account for pre-fitted module prices drifting slightly over time. This is such a bizarre system...

Arcitec commented 1 month ago

Shifts by a few credits are part of the background simulation when dealing with commodities.

So it makes perfect sense that the same thing happens for ships and modules.

Most likely, Frontier considered making the fluctuations way bigger from station to station, and they clearly have the code for that, but then they obviously decided to keep them basically the same, so they probably set the fluctuation range to something low like +/- 10 credits.

This is just my theory but it makes sense with everything above.

taleden commented 1 week ago

Since the state of things still seems to be that nothing holds its exact same price for more than a few weeks, I'm going to stick to my round-to-10 strategy and close this for now.

If in the future you learn that some subset of modules really do have constant, unchanging prices, please re-open and I'll take another look!