taleden / EDSY

EDSY is a web-based ship outfitting simulator tool for the game Elite Dangerous
22 stars 7 forks source link

Add 'damage' to Guardian Shard Cannon modifiers #28

Open mgrzegor opened 4 months ago

mgrzegor commented 4 months ago

Hi taleden, this pull request is to add the 'damage' stat to Guardian Shard Cannon modifiers, so that EDSY can at least partially support imported loadouts containing Guardian Shard Cannons with the Anti-Guardian Zone Resistance blueprint (until the said blueprint is properly implemented in EDSY).

I wanted to also review the 'damage' stats of the shard cannons (now that we can see their original values in loadouts), but I see that the 'damage' stat does not match the OriginalValue from the Loadout events for any Guardian weapon. I guess you apply some kind of scaling factor, but I am not sure if it is consistent between different types of weapons, so I decided not to touch it. Instead, below I include Loadout events (stripped of irrelevant stuff) containing fixed Guardian weapons with the AGZR blueprint, so you can check them yourself:

Guardian plasma launchers & medium gauss cannon ```json { "event": "Loadout", "Ship": "cutter", "Modules": [ { "Slot": "HugeHardpoint1", "Item": "hpt_guardian_plasmalauncher_fixed_large", "On": true, "Priority": 0, "AmmoInClip": 15, "AmmoInHopper": 200, "Engineering": { "Engineer": "Ram Tah", "EngineerID": 300110, "BlueprintID": 129030458, "BlueprintName": "GuardianWeapon_Sturdy", "Level": 1, "Quality": 0.0, "Modifiers": [ { "Label": "Damage", "Value": 3.08, "OriginalValue": 3.85, "LessIsGood": 0 }, { "Label": "GuardianModuleResistance", "ValueStr": "$INT_PANEL_module_active;", "ValueStr_Localised": "Active" } ] } }, { "Slot": "MediumHardpoint1", "Item": "hpt_guardian_plasmalauncher_fixed_medium", "On": true, "Priority": 0, "AmmoInClip": 15, "AmmoInHopper": 200, "Engineering": { "Engineer": "Ram Tah", "EngineerID": 300110, "BlueprintID": 129030458, "BlueprintName": "GuardianWeapon_Sturdy", "Level": 1, "Quality": 0.0, "Modifiers": [ { "Label": "Damage", "Value": 2.2, "OriginalValue": 2.75, "LessIsGood": 0 }, { "Label": "GuardianModuleResistance", "ValueStr": "$INT_PANEL_module_active;", "ValueStr_Localised": "Active" } ] } }, { "Slot": "MediumHardpoint2", "Item": "hpt_guardian_plasmalauncher_fixed_small", "On": true, "Priority": 0, "AmmoInClip": 15, "AmmoInHopper": 200, "Engineering": { "Engineer": "Ram Tah", "EngineerID": 300110, "BlueprintID": 129030458, "BlueprintName": "GuardianWeapon_Sturdy", "Level": 1, "Quality": 0.0, "Modifiers": [ { "Label": "Damage", "Value": 1.32, "OriginalValue": 1.65, "LessIsGood": 0 }, { "Label": "GuardianModuleResistance", "ValueStr": "$INT_PANEL_module_active;", "ValueStr_Localised": "Active" } ] } }, { "Slot": "MediumHardpoint4", "Item": "hpt_guardian_gausscannon_fixed_medium", "On": true, "Priority": 0, "AmmoInClip": 1, "AmmoInHopper": 80, "Engineering": { "Engineer": "Ram Tah", "EngineerID": 300110, "BlueprintID": 129030458, "BlueprintName": "GuardianWeapon_Sturdy", "Level": 1, "Quality": 0.0, "Modifiers": [ { "Label": "DamagePerSecond", "Value": 37.108433, "OriginalValue": 46.385544, "LessIsGood": 0 }, { "Label": "Damage", "Value": 30.799999, "OriginalValue": 38.5, "LessIsGood": 0 }, { "Label": "GuardianModuleResistance", "ValueStr": "$INT_PANEL_module_active;", "ValueStr_Localised": "Active" } ] } } ] } ```
Guardian shard cannons & small gauss cannon ```json { "event": "Loadout", "Ship": "cutter", "Modules": [ { "Slot": "HugeHardpoint1", "Item": "hpt_guardian_shardcannon_fixed_large", "On": true, "Priority": 3, "AmmoInClip": 5, "AmmoInHopper": 180, "Engineering": { "Engineer": "Ram Tah", "EngineerID": 300110, "BlueprintID": 129030458, "BlueprintName": "GuardianWeapon_Sturdy", "Level": 1, "Quality": 0.0, "Modifiers": [ { "Label": "DamagePerSecond", "Value": 83.599998, "OriginalValue": 104.5, "LessIsGood": 0 }, { "Label": "Damage", "Value": 4.18, "OriginalValue": 5.225, "LessIsGood": 0 }, { "Label": "GuardianModuleResistance", "ValueStr": "$INT_PANEL_module_active;", "ValueStr_Localised": "Active" } ] } }, { "Slot": "MediumHardpoint2", "Item": "hpt_guardian_shardcannon_fixed_medium", "On": true, "Priority": 3, "AmmoInClip": 5, "AmmoInHopper": 180, "Engineering": { "Engineer": "Ram Tah", "EngineerID": 300110, "BlueprintID": 129030458, "BlueprintName": "GuardianWeapon_Sturdy", "Level": 1, "Quality": 0.0, "Modifiers": [ { "Label": "DamagePerSecond", "Value": 59.575996, "OriginalValue": 74.470001, "LessIsGood": 0 }, { "Label": "Damage", "Value": 2.9788, "OriginalValue": 3.7235, "LessIsGood": 0 }, { "Label": "GuardianModuleResistance", "ValueStr": "$INT_PANEL_module_active;", "ValueStr_Localised": "Active" } ] } }, { "Slot": "MediumHardpoint3", "Item": "hpt_guardian_shardcannon_fixed_small", "On": true, "Priority": 0, "AmmoInClip": 5, "AmmoInHopper": 180, "Engineering": { "Engineer": "Ram Tah", "EngineerID": 300110, "BlueprintID": 129030458, "BlueprintName": "GuardianWeapon_Sturdy", "Level": 1, "Quality": 0.0, "Modifiers": [ { "Label": "DamagePerSecond", "Value": 32.032001, "OriginalValue": 40.040001, "LessIsGood": 0 }, { "Label": "Damage", "Value": 1.6016, "OriginalValue": 2.002, "LessIsGood": 0 }, { "Label": "GuardianModuleResistance", "ValueStr": "$INT_PANEL_module_active;", "ValueStr_Localised": "Active" } ] } }, { "Slot": "MediumHardpoint4", "Item": "hpt_guardian_gausscannon_fixed_small", "On": true, "Priority": 0, "AmmoInClip": 1, "AmmoInHopper": 80, "Engineering": { "Engineer": "Ram Tah", "EngineerID": 300110, "BlueprintID": 129030458, "BlueprintName": "GuardianWeapon_Sturdy", "Level": 1, "Quality": 0.0, "Modifiers": [ { "Label": "DamagePerSecond", "Value": 21.204821, "OriginalValue": 26.506025, "LessIsGood": 0 }, { "Label": "Damage", "Value": 17.6, "OriginalValue": 22.0, "LessIsGood": 0 }, { "Label": "GuardianModuleResistance", "ValueStr": "$INT_PANEL_module_active;", "ValueStr_Localised": "Active" } ] } } ] } ```

Unfortunately, I cannot do the same with turreted Guardian weapons, as I never unlocked them. (If I understand correctly, only gunner crew can make them fire not forward, so I consider them pretty useless to me.)

Best regards MG