search

talegari / bigdist

Store Distance Matrices on Disk:
https://talegari.github.io/bigdist/
4 stars 2 forks source link

Use drop = FALSE to keep matrix dimensions #1

Closed privefl closed 5 years ago

privefl commented 5 years ago

I'll be happy to contribute to your package if you wish to. I was always interested in doing something about matrix distances with {bigstatsr} but never had the opportunity to do so (because I don't have this need in my current research).

You might want to add some tests in your package so that I'm sure I don't break your package while suggesting some changes.

privefl commented 5 years ago

For testing, have a look at https://privefl.github.io/advr38book/packages.html#pkg-tests For CI, have a look at https://privefl.github.io/advr38book/packages.html#pkg-ci

Florian

Le mer. 13 mars 2019 à 10:31, Srikanth K S notifications@github.com a écrit :

Merged #1 https://github.com/talegari/bigdist/pull/1 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/talegari/bigdist/pull/1#event-2199628222, or mute the thread https://github.com/notifications/unsubscribe-auth/AKpNzH4oMY_SKD69k-Oo8o31738fEepgks5vWMV3gaJpZM4bqX0V .

talegari commented 5 years ago

Thanks for the pointers, I will be setting up these things shortly.