search

talensgj / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
1 stars 0 forks source link

Bad pixel correction #18

Closed AntoineDarveau closed 2 years ago

AntoineDarveau commented 2 years ago

Fixes #10 Add possibility to correct bad pixel with the trace models. This option is the default.

loicalbert commented 2 years ago

Merci Antoine. The logic looks good to me. I haven't tested the code and won't be for the near future.

loicalbert commented 2 years ago

OK with the request.

AntoineDarveau commented 2 years ago

Question: Should we include the parameter to deal with bad pixels ('model' or 'masking') in Extract1dStep or just leave it with the default being 'model' when models are available?

loicalbert commented 2 years ago

I think it should be up one level such that we can modify the argument from the DMS step Extract1dStep. That way, users could alter it. It otherwise would not be possible for them to do so.

AntoineDarveau commented 2 years ago

Question: How to deal with the error for the masked pixels? Options I see:

  1. Put it to zero, so no effect on the uncertainties?
  2. Estimate based on the fit on the other non masked pixels, on the same column (so they cover a similar range).
  3. Use other valid pixel to estimate the uncertainty empirically