search

talensgj / jwst

Python library for science observations from the James Webb Space Telescope
https://jwst-pipeline.readthedocs.io/en/latest/
Other
1 stars 0 forks source link

Centroids bugfix #20

Closed radicamc closed 2 years ago

radicamc commented 2 years ago

Closes #6

Resolves JP-

Description

Added new test to deal with out of bounds pixels generated by the center-of-mass centroiding algorithm. All tests were successful - e.g., a call to Spec2Pipeline will work now and not throw errors.

Checklist

radicamc commented 2 years ago

I personally think the whole section (lines 162 - 170) where we do this second test can be removed. If we're masking either the first or second order before running the centroiding algorithm, we should never really be in a position where the centroid is falling in between two equally bright orders. But given the short timeline, its probably best to just leave it as it is, and I'll fix up the test.

radicamc commented 2 years ago

No idea why all these checks are failing... Everything still runs fine?

talensgj commented 2 years ago

The tests carried over from the main repository. I think the planned rebase should fix them.

radicamc commented 2 years ago

@talensgj Done.

radicamc commented 2 years ago

Hm, I wonder why pycharm didn't flag that. But removed now!