Closed helloanil closed 6 months ago
@coderabbitai
@helloanil
Absolutely, let's tackle this step by step. Please let me know the specific details or tasks you'd like to address, and I'll assist you accordingly.
@coderabbitai
Can you do a review for this Pull Request? Please check if I follow the best practices.
@helloanil
I will initiate a review to ensure best practices are being followed in your pull request.
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository.To trigger a single review, invoke the
@coderabbitai review
command.
The update encompasses enhancements to a Salesforce API repository, with improved sorting capabilities that now support arrays. A new CareerPartnerBanner
React component has been introduced, complete with its own styling and integration into a page. Styles have been adjusted for better responsiveness, and a new icon has been added to the shared components library, indicating an expansion of visual elements related to career partnerships.
File Path | Change Summary |
---|---|
.../sf-api.repository.ts |
Enhanced sorting with isArray , support for multiple orderBy tuples, and constants for records and result . |
.../CareerPartnerBanner.scss .../CareerPartnerBanner.tsx |
Introduced styles and React component for CareerPartnerBanner . |
.../LoggedIn.scss |
Adjusted width property of .main-container--horizontal-spacer class. |
.../EditableAbout.tsx |
Simplified rendering of the "About" section. |
.../EditableJobPostings.generated.ts |
Included additional field isFromCareerPartner in LoadModalFormJobListingDataQuery type. |
.../sort-job-listings.ts |
Introduced careerPartnerSortFn for sorting job listings based on career partner status. |
.../Icon.tsx |
Added new careerPartnerBadge icon and its associated import. |
.../tp-job-listing.record.ts .../tp-job-listing.recordprops.ts |
Modified to include Account__r.Career_Partner__c field. |
.../tp-job-listing.entityprops.ts |
Added new property isFromCareerPartner . |
.../tp-job-listing.mapper.ts |
Added isFromCareerPartner property to the props object. |
.../tp-job-listing-find-all-visible.query.generated.ts |
Modified to include isFromCareerPartner field in the array of TpJobListing . |
.../tp-job-listing.fragment.generated.ts .../tp-job-listing.fragment.graphql |
Included new field isFromCareerPartner in the AllTpJobListingFieldsFragment type. |
.../my-tp-data.generated.ts |
Modified to include isFromCareerPartner property in tpJobseekerDirectoryEntry . |
.../types.ts |
Removed fields from FindAllVisibleTpJobseekerDirectoryEntriesFilter type and added isFromCareerPartner field to TpJobListing type. |
.../TpJobListing.ts |
Added the isFromCareerPartner property of type boolean. |
.../schema.graphql |
Removed three boolean fields and added isFromCareerPartner field to the TpJobListing type. |
"In code we hop, with tuples align, 🐇
Sorting arrays, with elegance we refine.
Banners unfurl, partners in view,
A badge of honor, for the career crew."
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@coderabbitai review
@coderabbitai review
Ticket
816
Descriptions
This PR adds Career Partner feature. When this PR is merged and deployed, companies marked as Career Partner on Salesforce will have an indicator on their profile, where they can see since when they are a partner, and also how many jobs they currently have posted.
This also adds prioritising job listings from career partner companies when listed by jobseekers.
Important Note: To achieve sorting job listings by two different features, (career partner companies & lastUpdatedAt), an additional change was needed in the sf-api.
Screenshots
Summary by CodeRabbit
Summary by CodeRabbit
New Features
CareerPartnerBanner
component to display career partner information, such as tenure and number of jobs posted.Enhancements
CareerPartnerBanner
with styles for different screen sizes.Bug Fixes
orderBy
functionality.Style
careerPartnerBadge
icon to enhance visual representation of career partners.Documentation