Closed rebecakipper closed 6 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository.To trigger a single review, invoke the
@coderabbitai review
command.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Nice detective work here @rebecakipper! Merging & deploying.
Code for the 2 x Stepper components is the same, except for the steps
array and the determineCurrentStep
function.
I see a quick win: create a single <OnboardingSteps steps={} determineStep={} />
component in apps/redi-talent-pool/src/components/molecules
that we then use in
<JobseekerProfileForJobseekerEyes>
<MeCompany>
What do you think? Could you do something along these lines?
@ericbolikowski, I think that when the CON stepper is implemented, we can use the same design to re-implement the TP stepper & refactor. What do you think?
What Github issue does this PR relate to? Insert link.
842
What should the reviewer know?
The company's stepper design has a UI bug, exhibiting issues such as a broken general layout, lack of borders, and misalignment of text and symbols. Please refer to the screenshots below for visual details.
Previously the profile pages (
MeCompany.tsx
&MeJobseeker.tsx
) had the same parentredi-talent-pool/src/pages/app/me/Me.tsx.
Each page had anOnboardingSteps
component, but onlyMeJobseeker.tsx
had a style fileMeJobseeker.scss
imported to it. Since those styles were global andMeCompany.tsx
&MeJobseeker.tsx
shared the parent, the styles were also applied toMeCompany.tsx
, that uses the same classnames.Currently, the profile pages don’t share a parent anymore, because the jobseeker profile now has id based urls.
MeJobseeker.tsx
becameJobseekerProfileForJobseekerEyes.tsx
andMeJobseeker.scss
becameJobseekerProfileForJobseekerEyes.scss
underredi-talent-pool/src/pages/app/jobseeker-profile
.This PR solves the issue by creating dedicated styles for
TpCompanyProfileOnboardingSteps.tsx
, based on the original style fromJobseekerProfileForJobseekerEyes.scss
.