Closed helloanil closed 4 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository.To trigger a single review, invoke the
@coderabbitai review
command.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@ericbolikowski what do you feel about the login-error URL?
It's not really an error, but restricted access. Maybe we can think about better wording, something like unauthorized-access
or access-denied
?
What Github issue does this PR relate to? Insert link.
800
What should the reviewer know?
This PR changes the behavior of redirecting PENDING, REJECTED and DEACTIVATED TP Company Representatives. Previously we were redirecting them to Signup Verification Success page, but with this PR, we are creating a new page for REJECTED and DEACTIVATED Reps and redirecting PENDING Reps to Signup Complete page. (Screenshots below)
Open Questions
There are a few open questions that can change the implementation when answered:
login-error
URL? It sounds very generic but it's actually only being used for TP Comp Reps. Any better ideas?Screenshots
REJECTED/DEACTIVATED TP Comp Reps:![CleanShot 2024-02-12 at 23 29 55](https://github.com/talent-connect/connect/assets/6314657/9a88ef9e-7243-4d59-b0bf-bca8fd2af64a)
PENDING TP Comp Reps:![CleanShot 2024-02-12 at 23 33 06](https://github.com/talent-connect/connect/assets/6314657/be654285-511f-4e05-8089-f67a07e369de)