talent-connect / connect

Mentor-mentee and jobseeker-company matchmaking platform used by ReDI School of Digital Integration, in Berlin, Munich and Düsseldorf, Germany.
https://connect.berlin.redi-school.org
19 stars 8 forks source link

Tp con/improve design job seeker and mentor cards #876

Closed rebecakipper closed 4 months ago

rebecakipper commented 4 months ago

What Github issue does this PR relate to? Insert link.

681 & #819

What should the reviewer know?

This PR aims at implementing the design for a single card used for mentors in CON and jobseekers in TP.

previous CON: Screenshot 2024-02-27 at 14 53 27Screenshot 2024-02-27 at 14 56 12

new CON: Screenshot 2024-02-27 at 14 59 54Screenshot 2024-02-27 at 14 59 03

previous TP: Screenshot 2024-02-27 at 14 55 31Screenshot 2024-02-27 at 14 55 55

new TP:

Screenshot 2024-02-27 at 14 59 59Screenshot 2024-02-27 at 14 59 18

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

This update introduces a series of enhancements across different components and libraries, focusing on improving the user interface and experience of profile cards for mentors, jobseekers, and job listings. It includes the introduction of new components like MentorProfileCard and NewProfileCard, the refactoring of existing components, and the standardization of design elements across applications to improve code sharing and design consistency.

Changes

File Path Change Summary
apps/redi-connect/.../MentorProfileCard.scss
apps/redi-connect/.../MentorProfileCard.tsx
Introduced a new MentorProfileCard component with styling and functionality.
apps/redi-connect/.../FindAMentor.tsx Updated to use MentorProfileCard instead of ProfileCard.
apps/redi-talent-pool/.../JobListingCard.scss Removed styling for location elements in JobListingCard.
apps/redi-talent-pool/.../JobListingCard.tsx
libs/shared-atomic-design-components/.../CardLocation.tsx
Moved CardLocation component to shared library.
apps/redi-talent-pool/.../JobseekerProfileCard.generated.ts
apps/redi-talent-pool/.../JobseekerProfileCard.graphql
Updated JobseekerProfileCard fragment to include location and workingLanguages.
apps/redi-talent-pool/.../JobseekerProfileCard.scss
apps/redi-talent-pool/.../JobseekerProfileCard.tsx
Refactored JobseekerProfileCard component and styling.
libs/shared-atomic-design-components/.../CardLocation.scss
libs/shared-atomic-design-components/.../NewProfileCard.scss
Introduced styling for CardLocation and NewProfileCard components.
libs/shared-atomic-design-components/.../CardTags.scss
libs/shared-atomic-design-components/.../CardTags.tsx
Updated styling and class names in CardTags.
libs/shared-atomic-design-components/.../NewProfileCard.tsx Introduced a new NewProfileCard component.

Related issues

🐰✨
In the land of code and design, where changes bloom and intertwine,
A rabbit hopped, with joy did share, updates that were crafted with care.
From mentor cards to seekers' view, a transformation, bold and new,
With every line, a story told, of profiles cast in modern mold.
🌟So here's to progress, hand in hand, across the digital land.✨🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
astkhikatredi commented 4 months ago

Dear @helloanil , kind reminder :)

helloanil commented 4 months ago

@coderabbitai review

ericbolikowski commented 4 months ago

🐇

helloanil commented 4 months ago

@astkhikatredi It looks good to me in general. Just one thing we can get rid of, Hired tag on jobseekers. I remember we talked about this but I don't remember the conclusion. Should we completely remove it?

astkhikatredi commented 4 months ago

Hey @helloanil, thanks for the question! Let's keep tags for now. Paulina will check whether it's still needed when she is back from holidays. Thanks

helloanil commented 4 months ago

@astkhikatredi Then I'm happy to approve this PR. I will merge and deploy tomorrow.