search

talent-connect / connect

Mentor-mentee and jobseeker-company matchmaking platform used by ReDI School of Digital Integration, in Berlin, Munich and Düsseldorf, Germany.
https://connect.berlin.redi-school.org
19 stars 8 forks source link

Tp/feat/new job posting page design #916

Closed rebecakipper closed 3 weeks ago

rebecakipper commented 1 month ago

What Github issue does this PR relate to? Insert link.

closes #904

What should the reviewer know?

This PR implements the design for the JobPostings Page.

Previous >> Current (Desktop): Screenshot 2024-05-22 at 16 02 19. Screenshot 2024-05-22 at 15 58 46

Previous >> Current (Tablet): Screenshot 2024-05-22 at 16 01 50. Screenshot 2024-05-22 at 15 59 11

Previous >> Current (Mobile): Screenshot 2024-05-22 at 16 01 31. Screenshot 2024-05-22 at 15 59 29

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent changes introduced significant updates to the JobListing page, involving substantial refactoring for improved maintainability and readability. Key modifications include restructuring components, enhancing job listing displays, and refining styles to align with the new design requirements. Additionally, there were updates to the CardLocation, SVGImage, and Chip components to support the revised functionality.

Changes

File / Group of Files Change Summary
apps/redi-connect/src/components/molecules/ReadMentoringTopics.tsx Refactored Chip import path.
apps/redi-talent-pool/src/pages/app/job-listing/JobListing.scss Added new imports and styles for .profile-section, .responsive-section, and .jobListing for better responsiveness and enhanced layout.
apps/redi-talent-pool/src/pages/app/job-listing/JobListing.tsx Refactored job listing component into smaller sub-components; updated imports and improved layout and styling of job listing details.
libs/shared-atomic-design-components/src/lib/atoms/CardLocation.tsx Improved type safety by specifying types for location and remote props.
libs/shared-atomic-design-components/src/lib/atoms/SVGImage.tsx Added new SVG image for 'location' and introduced a new type ImageProp.
libs/shared-atomic-design-components/src/lib/atoms/index.ts Added exports for CardLocation and Chip.

Sequence Diagram(s)

Assessment against linked issues

Objective Addressed Explanation
New styles and sizes for main title, section titles, and "Last update" info (#904) ✅
"Details" section renamed to "Contact" with updated contents and location (#904) ✅
Second line of chips for the "ideal technical skills" (#904) ✅

Poem

In a code den so bright and new,
Components restructured, old into few.
Styles refreshed, chips in line,
For job listings, polished shine.
With type-safe props and SVG of site,
Jobseekers find a delight in their sight.
🌟🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
astkhikatredi commented 1 month ago

Dear @ericbolikowski, kind reminder

astkhikatredi commented 3 weeks ago

Dear @ericbolikowski, could you please review PR? It would be great to merge and deploy if everything is alright. Thank you

ericbolikowski commented 3 weeks ago

And @astkhikatredi, thanks for the patience <3 happy this one is done now