Feature/connect/display rejected status page #889

[Ameer-Alaswad]

What Github issue does this PR relate to? Insert link.

Ticket #889

What should the reviewer know?

• adds notifications to both mentees and mentors with deactivated/rejected status
• adds /front/login-result route
• When con users with statuses deactivated/rejected login will get redirected to /front/login-result without getting logged in.

Mentee status notification :

Mentor status notification :

Mentee/Mentor login deactivated/rejected status:

Summary by CodeRabbit

• New Features

  • Introduced new notifications for rejected mentees and mentors.
  • Added a new LoginError component to inform users about changes to platform access.
  • Added a new route for the LoginError page.

• Enhancements

  • Improved login flow with conditional redirection based on profile status.
  • Updated API logic to handle potential null values more gracefully.

• Bug Fixes

  • Fixed issue where imports were not consistently organized on save in the editor settings.

[coderabbitai[bot]]

Walkthrough

The recent changes across multiple files in the ReDI Connect project focus on enhancing user experience and improving functionality. Key updates include conditional notifications for rejected profiles, restructuring login logic, introducing a new error component, and modifying import organization settings. These changes aim to streamline user interactions, provide clearer feedback, and ensure smoother navigation and error handling within the application.

Changes

File Path	Change Summary
.vscode/settings.json	Adjusted editor.codeActionsOnSave to explicitly trigger organize imports action.
.../locales/en/translation.json	Added messages for "rejectedMentee" and "rejectedMentor" notifications.
.../components/templates/LoggedIn.tsx	Added conditional rendering for notifications based on profile.userType and profileStatus.
.../pages/front/login/Login.tsx	Restructured fetcher call, added redirection logic based on conProfile status.
.../pages/front/login/LoginError.tsx	Introduced LoginError component to display access change messages with navigation options.
.../routes/routes__logged-out.tsx	Added lazy-loaded LoginError component and corresponding route /front/login-result.
.../services/api/api.tsx	Updated assignment of accessToken with null check (?.) on loginResp.data.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LoginPage
    participant API
    participant Dashboard
    participant LoginErrorPage

    User->>LoginPage: Attempt to login
    LoginPage->>API: Fetch user profile
    API-->>LoginPage: Return conProfile
    alt conProfile is rejected
        LoginPage->>LoginErrorPage: Redirect to /front/login-result
        LoginErrorPage-->>User: Display rejection message
    else conProfile is accepted
        LoginPage->>Dashboard: Redirect to dashboard
        Dashboard-->>User: Display user dashboard
    end

Poem

In code, we tweak and mend, With changes that never end, Notifications clear and bright, Guide you through day and night. Login smooth, errors few, For a journey fresh and new! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[astkhikatredi]

Dear @Ameer-Alaswad, thanks a loooot! Dear @helloanil and @Ameer-Alaswad, I have a question here: do we use the same approach as for TP?

If I am not mistaken, For TP: deactivated/rejected users can't log in at all and instead are redirected to the page with a notification, am I right? Here you can see the video from TP.

In this solution as far as I understand user will see a page with a notification (super cool), but can still log in and see a banner?

Thank you for the explanation!

[Ameer-Alaswad]

Dear @Ameer-Alaswad, thanks a loooot! Dear @helloanil and @Ameer-Alaswad, I have a question here: do we use the same approach as for TP?

If I am not mistaken, For TP: deactivated/rejected users can't log in at all and instead are redirected to the page with a notification, am I right? Here you can see the video from TP.

In this solution as far as I understand user will see a page with a notification (super cool), but can still log in and see a banner?

Thank you for the explanation!

Thank you for pointing this out.

You are correct; for TP, deactivated/rejected users are indeed unable to log in and are redirected to a notification page. I apologize for the oversight in the current solution. The user should not be able to log in at all if they are deactivated/rejected.

I am currently working on a fix to ensure that deactivated/rejected users are redirected to the appropriate notification page without being able to log in.

[astkhikatredi]

Thanks for the great job, dear @Ameer-Alaswad . Let's wait for @helloanil 's feedback.

Thanks

[helloanil]

Well done @Ameer-Alaswad, the code looks great to me. I would like to give it a quick test tomorrow and if it's working as expected, I will also merge.

Great job 💪

[astkhikatredi]

Dear @helloanil any news? ready to merge and deploy?

[helloanil]

@astkhikatredi @Ameer-Alaswad I just tried to login with a deactivated CON account, and this is what I see:

I believe this is the same approach with the TP, as you discussed above. Then I'm happy to approve and merge this PR. Let me know.

[astkhikatredi]

@helloanil, yes, please. Thank you both!

[helloanil]

Hey @Ameer-Alaswad, unfortunately I have to revert this PR as it was breaking ReDI Connect Sign Up. Let's catch up on Monday so I can explain what happened.