search

talent-connect / connect

Mentor-mentee and jobseeker-company matchmaking platform used by ReDI School of Digital Integration, in Berlin, Munich and Düsseldorf, Germany.
https://connect.berlin.redi-school.org
19 stars 8 forks source link

Changed checkmark to "Save" #920

Closed Eyetsko closed 1 week ago

Eyetsko commented 3 weeks ago

What Github issue does this PR relate to? Insert link.

https://github.com/talent-connect/connect/issues/672

What should the reviewer know?

I changed the checkmark to the word "Save". I removed the hover effect. The functionality is otherwise the same: grey when disabled, orange when enabled.

I also tested using a different icon that was a disc, I added the "save" svg to the icons list and took screenshots, just to see this option. Added both here

Screenshot 2024-06-11 at 19 38 50 Screenshot 2024-06-11 at 19 39 01 Screenshot 2024-06-11 at 19 40 09 Screenshot 2024-06-11 at 19 40 20

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The recent updates focus on enhancing the Editable component in the shared atomic design library. These changes include substituting the existing save button implementation with a Button component featuring additional styling and a streamlined simple prop. Additionally, modifications have been made to organize code imports automatically in the VSCode settings.

Changes

File Path Change Summary
.vscode/settings.json Modified the setting for editor.codeActionsOnSave to use explicit organize imports.
libs/shared-atomic-design-components/.../Editable.scss Introduced specific styling for the save button and its disabled state, including margin, font size, color, text transformation, letter spacing, cursor, and a new .save__button--disabled class.
libs/shared-atomic-design-components/.../Editable.tsx Updated the class names for the save button, changed text content, replaced a div with a Button component including new simple prop, and added a line break before attributes.

Poem

In the code where changes blend, where imports sort and styles mend,
A button brand new, now stands in place, with simpler props and graceful space.
The save within our edit tale, now looks so sleek, where we prevail.
A rabbit cheers this neat design, in lines of code we redefine! 🌸

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
astkhikatredi commented 3 weeks ago

Thank you very much, dear @Eyetsko!

astkhikatredi commented 2 weeks ago

Dear @Eyetsko, any updates here? Thanks a lot!

Eyetsko commented 2 weeks ago

Used "Button" component suggested by Kate - screenshots attached

Screenshot 2024-06-21 at 13 28 43 Screenshot 2024-06-21 at 13 28 53
Eyetsko commented 2 weeks ago

completed all of the above requested by @katamatata - see attached screenshots

Screenshot 2024-06-22 at 14 42 55 Screenshot 2024-06-22 at 14 43 02
katamatata commented 1 week ago

@ericbolikowski, @helloanil, it seems that {"source.organizeImports": true} in the settings.json is deprecated in favor of {"source.organizeImports": "explicit"}.

image

Should be fine to commit it then, right?

helloanil commented 1 week ago

@ericbolikowski, @helloanil, it seems that {"source.organizeImports": true} in the settings.json is deprecated in favor of {"source.organizeImports": "explicit"}. image Should be fine to commit it then, right?

Hey @katamatata, yes it seems like since a specific version of VSCode, "explicit" is used. (My source: https://stackoverflow.com/questions/77637621/vscode-workspace-settings-change-on-its-own) We can keep it in the PR.