Closed katamatata closed 1 month ago
The changes primarily involve updating and reorganizing SCSS files to improve consistency and maintainability across the project. This includes updating comments, modifying import paths, converting color variables, and integrating global styles. Additionally, the Sentry initialization in main.tsx
was adjusted based on user acceptance, and a new path to fonts was added in the workspace.json
file.
File Path | Change Summary |
---|---|
apps/redi-connect/src/components/organisms/Navbar.scss |
Updated a comment to reference global.scss instead of main.scss for hover behavior class. |
apps/redi-connect/src/main.scss |
Added import statement for global.scss , integrating its styles. |
apps/redi-connect/src/main.tsx |
Moved import of main.scss and adjusted Sentry initialization based on user acceptance. |
apps/redi-talent-pool/src/components/organisms/Navbar.scss |
Updated a comment to reflect a change in where a style behavior is defined. |
apps/redi-talent-pool/src/components/templates/LoggedIn.scss |
Changed background color for .tp-side-menu class from #eff6f8 to $redi-blue-light . |
apps/redi-talent-pool/src/main.scss |
Updated import statement from _main.scss to global.scss . |
apps/redi-talent-pool/src/pages/.../JobseekerProfileForJobseekerEyes.scss |
Replaced color variables $tp-light-blue and $tp-blue with $grey-light and new blue shades. |
apps/redi-talent-pool/src/pages/.../TpCompanyProfileOnboardingSteps.scss |
Updated imports, color variables, and class styling, changing border color to $grey-light . |
libs/shared-atomic-design-components/src/lib/styles/_forms.scss |
Updated import statement to remove directory reference. |
libs/shared-atomic-design-components/src/lib/styles/global.scss |
Reorganized imports, updated import paths, adjusted custom modifiers, and added .block-separator . |
workspace.json |
Added new path to fonts under stylePreprocessorOptions in includePaths array within styles . |
In the land of code, neat and bright, Where styles and colors take their flight, SCSS files in harmony sing, Global hues and imports bring. A rabbit hops with cheer and glee, For organized code is a sight to see! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
What Github issue does this PR relate to? Insert link.
No issue.
What should the reviewer know?
In this PR, I consolidated styles in one
.scss
file withinshared-atomic-design-components
library aiming to centralize styling for easier maintenance and consistency across applications.global.scss
fileThe new structure of the style files in our Nx monorepo:
Note: SCSS partials are a feature of Sass that allows you to modularize your CSS and help keep things easier to maintain. Partials are SCSS files named with a leading underscore (e.g.,
_reset.scss
,_variables.scss
,_mixins.scss
). The underscore tells Sass that this file is a partial and should not be compiled into a standalone CSS file. Instead, partials are meant to be imported into other SCSS files.Summary by CodeRabbit
Style
Chores
global.scss
into main stylesheets to streamline styling.