talent-connect / connect

Mentor-mentee and jobseeker-company matchmaking platform used by ReDI School of Digital Integration, in Berlin, Munich and Düsseldorf, Germany.
https://connect.berlin.redi-school.org
20 stars 9 forks source link

feat: consolidate styles in global.scss in shared-atomic-design-components library #931

Closed katamatata closed 1 month ago

katamatata commented 1 month ago

What Github issue does this PR relate to? Insert link.

No issue.

What should the reviewer know?

In this PR, I consolidated styles in one .scss file within shared-atomic-design-components library aiming to centralize styling for easier maintenance and consistency across applications.

The new structure of the style files in our Nx monorepo:

connect/
├── apps/
│   ├── redi-connect/
│   │   ├── src/
│   │   │   ...
│   │   │   ├── main.tsx
│   │   │   └── main.scss // imports global.scss from shared-atomic-design-components
│   │   ...
│   ├── redi-talent-pool/
│   │   ├── src/
│   │   │   ...
│   │   │   ├── main.tsx
│   │   │   └── main.scss // imports global.scss from shared-atomic-design-components
│   │   ...
├── libs/
...
│   ├── shared-atomic-design-components/
│   │   ├── src/
│   │   │   ├── lib/
│   │   │   |   ...
│   │   │   │   ├── styles/
│   │   │   │   │   ├── _fonts.scss
│   │   │   │   │   ├── _forms.scss
│   │   │   │   │   ├── _variables.scss
│   │   │   │   │   └── global.scss // imports partials _fonts, _forms and _variables
│   │   ...
...

Note: SCSS partials are a feature of Sass that allows you to modularize your CSS and help keep things easier to maintain. Partials are SCSS files named with a leading underscore (e.g., _reset.scss, _variables.scss, _mixins.scss). The underscore tells Sass that this file is a partial and should not be compiled into a standalone CSS file. Instead, partials are meant to be imported into other SCSS files.

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes primarily involve updating and reorganizing SCSS files to improve consistency and maintainability across the project. This includes updating comments, modifying import paths, converting color variables, and integrating global styles. Additionally, the Sentry initialization in main.tsx was adjusted based on user acceptance, and a new path to fonts was added in the workspace.json file.

Changes

File Path Change Summary
apps/redi-connect/src/components/organisms/Navbar.scss Updated a comment to reference global.scss instead of main.scss for hover behavior class.
apps/redi-connect/src/main.scss Added import statement for global.scss, integrating its styles.
apps/redi-connect/src/main.tsx Moved import of main.scss and adjusted Sentry initialization based on user acceptance.
apps/redi-talent-pool/src/components/organisms/Navbar.scss Updated a comment to reflect a change in where a style behavior is defined.
apps/redi-talent-pool/src/components/templates/LoggedIn.scss Changed background color for .tp-side-menu class from #eff6f8 to $redi-blue-light.
apps/redi-talent-pool/src/main.scss Updated import statement from _main.scss to global.scss.
apps/redi-talent-pool/src/pages/.../JobseekerProfileForJobseekerEyes.scss Replaced color variables $tp-light-blue and $tp-blue with $grey-light and new blue shades.
apps/redi-talent-pool/src/pages/.../TpCompanyProfileOnboardingSteps.scss Updated imports, color variables, and class styling, changing border color to $grey-light.
libs/shared-atomic-design-components/src/lib/styles/_forms.scss Updated import statement to remove directory reference.
libs/shared-atomic-design-components/src/lib/styles/global.scss Reorganized imports, updated import paths, adjusted custom modifiers, and added .block-separator.
workspace.json Added new path to fonts under stylePreprocessorOptions in includePaths array within styles.

Poem

In the land of code, neat and bright, Where styles and colors take their flight, SCSS files in harmony sing, Global hues and imports bring. A rabbit hops with cheer and glee, For organized code is a sight to see! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.