talent-plan / tinysql

A course to build the SQL layer of a distributed database.
Apache License 2.0
1.7k stars 519 forks source link

Confusing test case in `2pc_test.go/TestPrewriteRollback` #118

Closed czt1999 closed 2 years ago

czt1999 commented 2 years ago

This test seems to validate the new value of key b while only key a is committed (see 2pc_test.go#L165) .Maybe some comments could be added to explain this counterintuitive design. Maintaining such a complicated learner-oriented project is hard. I hope I can help although still struggling with the code. Really appreciate your work :)