search

tales / tales-client

Moved to https://gitlab.com/tales/tales-client
http://www.manasource.org/
GNU General Public License v2.0
13 stars 5 forks source link

Inconsistencies in questlog after logging out and back in #26

Open jtoelke opened 9 years ago

jtoelke commented 9 years ago

Sometimes when you log out and and back in the questlog might display a quest in an earlier state than it actually is. It was displayed correctly before logging out.

Example: I completed the tutorial and it was displayed as finished. When I logged back in the tutorial quest was displayed as not finished on some earlier step in the questlog. The actual quest state when talking to the NPCs was correct.

I wasn't yet able to find a way to reproduce it reliably, it just sometimes happens.

Ablu commented 9 years ago

Do you remember wether you restarted the client during this? On 4 Dec 2014 23:08, "jtoelke" notifications@github.com wrote:

Sometimes when you log out and and back in the questlog might display a quest in an earlier state than it actually is. It was displayed correctly before logging out.

Example: I completed the tutorial and it was displayed as finished. When I logged back in the tutorial quest was displayed as not finished on some earlier step in the questlog. The actual quest state when talking to the NPCs was correct.

I wasn't yet able to find a way to reproduce it reliably, it just sometimes happens.

— Reply to this email directly or view it on GitHub https://github.com/tales/tales-client/issues/26.

jtoelke commented 9 years ago

Yes, I think I restarted the client. (Because I don't know how to exit to character selection or server selection...) I probably also restarted the server, since I was experiencing this during testing of new quests.

bjorn commented 9 years ago

Because I don't know how to exit to character selection or server selection...

You can do this with the Backspace key (or the regular back button when on an Android device).

Ablu commented 9 years ago

Attribute and correction points are also gone if you reconnect quickly after not disconnecting properly (using the backspace key). If you wait a bit and reconnect they are there. I guess it has to do with the special reconnecting logic when the game server detects a reconnection and simply hands over the existing character. This probably does not trigger the login trigger and hence does not send the questlog either.

Ablu commented 9 years ago

While debugging a quest issue of @wushin i remembered that quests are now stored to the database... So we currently have to make sure to set the quest variables but also the logs... This is very error prone... I think we need to find a way how it works in a way it cannot possibly get un-synchronised.