search

tales / tales-client

Moved to https://gitlab.com/tales/tales-client
http://www.manasource.org/
GNU General Public License v2.0
13 stars 5 forks source link

Implement Shop UI #3

Open Ablu opened 9 years ago

Ablu commented 9 years ago

Currently the shop ui is lacking while the code in behind is there in theory.

Ablu commented 9 years ago

@bjorn: Did you had any ideas on how shop interaction could work?

What do you think about a temporary tab in the left side panel which has the shop contents. Tapping an entry could expand the item and show detailed info about the effect of the item (description, attribute modifiers, ...). For non-stackable items it could then show a buy button and for stackable ones a slider with an selectable amount + buy button.

Any other ideas?

bjorn commented 9 years ago

Your suggestions sound fine to me.

Ablu commented 9 years ago

Does the buy limit really make any sense?

I mean the item amount in http://doc.manasource.org/scripting.html#trade? I mean you can just close the trade and make a new one and have all items again...

bjorn commented 9 years ago

@Ablu While it is true that currently you can just reopen the shop to reset the buyable amounts, I imagine the purpose of this was to be able to handle shops with a persistent inventory. Though of course, the current implementation is a long way from making that possible.

Actually having to reopen the shop does make abusing too low shop prices much more annoying at least...

Ablu commented 9 years ago

I think for persistent shops we need some kind of global shared shop which can update even while the player is having it open (so callbacks on the server side can add and remove items).

On 12/20/2014 10:30 PM, Thorbjørn Lindeijer wrote:

@Ablu https://github.com/Ablu While it is true that currently you can just reopen the shop to reset the buyable amounts, I imagine the purpose of this was to be able to handle shops with a persistent inventory. Though of course, the current implementation is a long way from making that possible.

Actually having to reopen the shop does make abusing too low shop prices much more annoying at least...

— Reply to this email directly or view it on GitHub https://github.com/tales/tales-client/issues/3#issuecomment-67750487.

Ablu commented 9 years ago

The first part was merged. You can now at least buy stuff with a kind of presentable ui.

Ablu commented 9 years ago

Is there any reason why we need the modes BuyFromShop and SellToShop as two different modes? Can't we simply allow selling and buying in the same mode?

bjorn commented 9 years ago

I'd suggest we merge these modes as well.