tales / tales-client

Moved to https://gitlab.com/tales/tales-client
http://www.manasource.org/
GNU General Public License v2.0
13 stars 5 forks source link

Allow autoconnect #30

Closed Ablu closed 9 years ago

Ablu commented 9 years ago

Can I push this?

bjorn commented 9 years ago

Please keep the command line parameters all lowercase. It is quite unusual for having camel-case there. Also, I think "characterIndex" can just be renamed to "character" (at least as a command-line option). Later on we can make it work with character names as well.

Ablu commented 9 years ago

I just found that customserverlistmodel or customserver looks weird. Shall I do custom-server-list-model and custom-server instead?

About character. I am fine with it. However I do not think we need to blow this up a lot more... I think we should rather add a proper ui for autologin / auto character picking.

Ablu commented 9 years ago

UPDATE: Eh... nevermind... I looked at the contex strings not the options itself...

bjorn commented 9 years ago

I've fine with dashes, they're common in command-line parameters (though not for username).

I didn't mean adding support for auto-login by character name is a priority. I fully agree we have other stuff to do and this is probably something that will only become relevant once there would be a desktop-specific client, if at all.

Ablu commented 9 years ago

Well we do not need dashes i think... I looked at the wrong strings :)

Well I pushed a followup fix. Fine to merge with that?

bjorn commented 9 years ago

Only if you fix the "custom-server-list-path"...