Closed Ablu closed 9 years ago
Please keep the command line parameters all lowercase. It is quite unusual for having camel-case there. Also, I think "characterIndex" can just be renamed to "character" (at least as a command-line option). Later on we can make it work with character names as well.
I just found that customserverlistmodel
or customserver
looks weird. Shall I do custom-server-list-model
and custom-server
instead?
About character
. I am fine with it. However I do not think we need to blow this up a lot more... I think we should rather add a proper ui for autologin / auto character picking.
UPDATE: Eh... nevermind... I looked at the contex strings not the options itself...
I've fine with dashes, they're common in command-line parameters (though not for username
).
I didn't mean adding support for auto-login by character name is a priority. I fully agree we have other stuff to do and this is probably something that will only become relevant once there would be a desktop-specific client, if at all.
Well we do not need dashes i think... I looked at the wrong strings :)
Well I pushed a followup fix. Fine to merge with that?
Only if you fix the "custom-server-list-path"...
Can I push this?