search

tales / tales-client

Moved to https://gitlab.com/tales/tales-client
http://www.manasource.org/
GNU General Public License v2.0
13 stars 5 forks source link

walking away from an npc while talking to it crashes client and server #44

Open Schaefers opened 9 years ago

Schaefers commented 9 years ago

When starting to talk to a npc and than walking away from it makes it impossible to close the dialog and the client (in this case on Android) shows the "not logged in"-message. After trying to login again the client shows "No Gameserver found for Map the character is on". @Ablu confirmed that the server crashed.

Ablu commented 9 years ago

Does the client actually crash or only disconnect?

Ablu commented 9 years ago

The critical part is fixed. The server no longer crashs now.

However it looks like the client is sending some uninitialised memory as the public id? (at least the server receives a negative number).

So what is left is to fix this undefined behaviour and close the dialoge on the clientside if we go too far away.

bjorn commented 9 years ago

Just for reference, the fix was in commit mana/manaserv@1518b8f914c389538b2efcaba3bce64707278b74