search

talgalili / d3heatmap

A D3.js-based heatmap htmlwidget for R
Other
236 stars 95 forks source link

Updated dendrogram parameter behavior to only modify plotting behavior #36

Closed khughitt closed 3 years ago

khughitt commented 9 years ago

In heatmap.2() the dendrogram parameter only affects whether or not the dendrograms are drawn, not how the columns and rows are actually ordered.

I removed the logic that uses dendrogram to determine how Rowv and Colv should behave, and instead adopted the same behavior as heatmap.2.

garthtarr commented 8 years ago

+1 This is great - I just ran into this issue too

talgalili commented 3 years ago

Hey there, I'm planning to merge https://github.com/talgalili/d3heatmap/pull/86 into the package.

Could you verify if your PR adds to it or not?

Thanks!

(sorry for responding 4 years later :D I just took over maintaining the package)

khughitt commented 3 years ago

Hi @talgalili

No problem! Thanks for taking over for the project.

I did a quick check and it looks like that PR should indeed resolve this issue.

I'll close this one for now.

Cheers, Keith