search

talgalili / d3heatmap

A D3.js-based heatmap htmlwidget for R
Other
236 stars 95 forks source link

add drop=F to reordering #56

Open mkuhn opened 8 years ago

mkuhn commented 8 years ago

Without this change, the heatmap will not work when the user only has one row or one column

talgalili commented 3 years ago

Hey there, I'm planning to merge https://github.com/talgalili/d3heatmap/pull/86 into the package.

Could you verify if your PR adds to it or not?

Thanks!

(sorry for responding 4 years later :D I just took over maintaining the package)

mkuhn commented 3 years ago

Thanks for taking this over! I've long forgotten for which project I needed this :)

Looking at the code in #86, the problems addressed by this PR would still be there. So it would be good if you could also merge it in.

talgalili commented 3 years ago

Will do, thanks :)