talgalili / dendextend

Extending R's Dendrogram Functionality
153 stars 29 forks source link

.Rd files to fix #125

Closed talgalili closed 2 months ago

talgalili commented 2 months ago
* checking Rd files ... NOTE
checkRd: (-1) assign_values_to_leaves_edgePar.Rd:60: Lost braces
    60 | \link{get_leaves_attr}, link{assign_values_to_leaves_nodePar}
       |                             ^
checkRd: (-1) khan.Rd:10-11: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:12-13: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:14-15: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:16-18: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:19-21: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:22-35: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:26: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:27: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:28: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:29: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:30: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:31: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:32: Lost braces in \itemize; meant \describe ?
checkRd: (-1) khan.Rd:33: Lost braces in \itemize; meant \describe ?
checkRd: (-1) ladderize.Rd:59: Lost braces; missing escapes or markup?
    59 | \code{\link{rev.dendrogram}}, \code{\link{rotate}} ({dendextend}), \code{\link[ape]{rotate}} ({ape})
       |                                                     ^
checkRd: (-1) ladderize.Rd:59: Lost braces; missing escapes or markup?
    59 | \code{\link{rev.dendrogram}}, \code{\link{rotate}} ({dendextend}), \code{\link[ape]{rotate}} ({ape})
       |                                                                                               ^
checkRd: (-1) prune.Rd:62: Lost braces; missing escapes or markup?
    62 | \link{prune_leaf}, \link[ape]{drop.tip} {ape}
       |                                         ^
checkRd: (-1) rllply.Rd:25: Lost braces; missing escapes or markup?
    25 | following the naming convention in the {plyr} package
       |                                        ^
checkRd: (-1) rotate.Rd:81: Lost braces; missing escapes or markup?
    81 | The {ape} package has its own \code{\link[ape]{rotate}}({ape}) function
       |     ^
checkRd: (-1) rotate.Rd:81: Lost braces; missing escapes or markup?
    81 | The {ape} package has its own \code{\link[ape]{rotate}}({ape}) function
       |                                                         ^
checkRd: (-1) rotate.Rd:86: Lost braces; missing escapes or markup?
    86 | Notice that if you will first load {ape} and only then {dendextend},
       |                                    ^
checkRd: (-1) rotate.Rd:86: Lost braces; missing escapes or markup?
    86 | Notice that if you will first load {ape} and only then {dendextend},
       |                                                        ^
checkRd: (-1) rotate.Rd:92: Lost braces; missing escapes or markup?
    92 |  The solution for this is that if you have {ape} installed on your machine,
       |                                            ^
checkRd: (-1) rotate.Rd:93: Lost braces; missing escapes or markup?
    93 |  It will be loaded when you load {dendextend} (but after it).
       |                                  ^
checkRd: (-1) rotate.Rd:134: Lost braces; missing escapes or markup?
   134 | \code{\link{rev.dendrogram}}, \code{\link[ape]{rotate}} ({ape}), \link{ladderize}
       |                                                          ^
checkRd: (-1) unbranch.Rd:47: Lost braces; missing escapes or markup?
    47 | \link[ape]{unroot} {ape}
       |                    ^
checkRd: (-1) untangle_DendSer.Rd:22: Lost braces
    22 | This is a good (and fast) starting point for link{untangle_step_rotate_2side}
       |                                                  ^
* checking Rd metadata ... OK
* checking Rd line widths ... NOTE
Rd file 'untangle_step_rotate_both_side.Rd':
  \examples lines wider than 100 characters:
     # Figures recreated from 'Shuffle & untangle: novel untangle methods for solving the tanglegram layout problem' (Nguyen et al. 2022)
     example_labels <- c("Versicolor 90", "Versicolor 54", "Versicolor 81", "Versicolor 63", "Versicolor 72", "Versicolor 99", "Virginica 13 ... [TRUNCATED]
talgalili commented 2 months ago

Hi @alecbuetow Before I can publish dendextend to CRAN, this will need to be fixed. Any chance you could take a look at it?

Thanks!

alecbuetow commented 2 months ago

Happy to take a look at it! I’ll be back in service 10/7

On Thu, Oct 3, 2024 at 6:40 AM Tal Galili @.***> wrote:

Hi @alecbuetow https://github.com/alecbuetow Before I can publish dendextend to CRAN, this will need to be fixed. Any chance you could take a look at it?

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/talgalili/dendextend/issues/125#issuecomment-2391204904, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXESKO7XFHH5IVJ3OFKBXLTZZUUKBAVCNFSM6AAAAABPA3RTK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJRGIYDIOJQGQ . You are receiving this because you were mentioned.Message ID: @.***>

talgalili commented 2 months ago

Fixed in: 1de78d049d93543762e1ebe3242f3ee9ec482b6c