search

talgalili / dendextend

Extending R's Dendrogram Functionality
153 stars 29 forks source link

Checking to see if tests cover load / unload hooks #149

Closed alecbuetow closed 2 weeks ago

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.40%. Comparing base (b0b7662) to head (4edc796). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #149 +/- ## ======================================= Coverage 99.40% 99.40% ======================================= Files 50 50 Lines 4184 4184 ======================================= Hits 4159 4159 Misses 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alecbuetow commented 2 weeks ago

Tests "successful" but coverage hasn't increased, I want going to keep playing with this until it covers the three remaining lines in zzz.R

talgalili commented 2 weeks ago

Thanks for trying! I think we should skip this. Adding two packages to the suggests just to test one line seems like a bit worthwhile trade-off.

99% coverage is also amazing. Shall we stop here? (And you can go over the other open issues I mentioned to you, these are more valuable to solve)

WDYT?

alecbuetow commented 2 weeks ago

Sounds good, I don't think its worthwhile either. I expected it to be easier than this lol