search

talgalili / dendextend

Extending R's Dendrogram Functionality
153 stars 29 forks source link

Inner nodes #70

Closed hummelma closed 6 years ago

hummelma commented 6 years ago

Hi Tal, there is now the function branches_attr_by_lists in branches_attr_by.R and a corresponding set("by_lists_branches_col", ...) in set.dendrogram.R. Respective .Rd files and the NAMESPACE are created/updated. I hope everything works fine. Best Manuela

codecov-io commented 6 years ago

Codecov Report

Merging #70 into master will increase coverage by 0.31%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   38.47%   38.78%   +0.31%     
==========================================
  Files          50       50              
  Lines        3912     3932      +20     
==========================================
+ Hits         1505     1525      +20     
  Misses       2407     2407
Impacted Files Coverage Δ
R/set.dendrogram.R 79.54% <100%> (+1.49%) :arrow_up:
R/branches_attr_by.R 17.89% <100%> (+17.89%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49dde87...c3c071b. Read the comment docs.

talgalili commented 6 years ago

Dear @hummelma , thank you for the great submission. Would you be able to just add a few simple unit tests of the functions you've added? (i.e.: testthat ?)

hummelma commented 6 years ago

I have added a unit test in tests/testthat/test-branches_attr_by.R

talgalili commented 6 years ago

Great, thanks! I'll have a look a bit later. Thanks for moving this forward.