Closed alanocallaghan closed 6 years ago
Merging #72 into master will increase coverage by
0.53%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 37.92% 38.46% +0.53%
==========================================
Files 51 50 -1
Lines 4021 3913 -108
==========================================
- Hits 1525 1505 -20
+ Misses 2496 2408 -88
Impacted Files | Coverage Δ | |
---|---|---|
R/seriate_dendrogram.R | 0% <0%> (ø) |
:arrow_up: |
R/branches_attr_by.R | 0% <0%> (-17.9%) |
:arrow_down: |
R/set.dendrogram.R | 78.04% <0%> (-1.5%) |
:arrow_down: |
R/colored_bars.R | 0% <0%> (ø) |
:arrow_up: |
R/colored_dots.R |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c0885f6...aa355cc. Read the comment docs.
Hi @Alanocallaghan Thank you for the PR.
This seems to cause an error in one of the tests, is it something you could fix? (I suspect that the test needs to be amended)
Sure, I'll have another look tomorrow, was just putting it together quickly
Hi @Alanocallaghan I see Travis reports a failure in the test:
══ testthat results ═══════════════════════════════════════════════════════════
OK: 358 SKIPPED: 0 FAILED: 1
1. Failure: seriate fails with duplicated labels (@test-rotate.R#97)
Error: testthat unit tests failed
Could you please have a look and fix it?
I can't figure this out, it works locally (though other tests break instead). Anyway not a major issue so I'll close
As discussed here: https://github.com/talgalili/heatmaply/issues/155
This doesn't alter existing behaviour, just gives a more intelligible error message