search

talgalili / dendextend

Extending R's Dendrogram Functionality
152 stars 28 forks source link

na.rm option for ggplot.ggdend #94

Closed alanocallaghan closed 4 years ago

alanocallaghan commented 4 years ago

Resolve #93

codecov-io commented 4 years ago

Codecov Report

Merging #94 into master will increase coverage by 1.38%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   34.58%   35.97%   +1.38%     
==========================================
  Files          50       50              
  Lines        3539     3539              
==========================================
+ Hits         1224     1273      +49     
+ Misses       2315     2266      -49
Impacted Files Coverage Δ
R/distinct_edges.R 50.87% <ø> (ø) :arrow_up:
R/ggdend.R 88.77% <100%> (+41.83%) :arrow_up:
R/ggdendro.R 75.2% <0%> (+6.4%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 901d812...1d1f3b6. Read the comment docs.

alanocallaghan commented 4 years ago

Hey @talgalili could you merge this? It allows me to remove some unsightly warnings when using ggheatmap. Cheers

talgalili commented 4 years ago

Done.

On Tue, Sep 24, 2019 at 12:19 AM Alanocallaghan notifications@github.com wrote:

Hey @talgalili https://github.com/talgalili could you merge this? It allows me to remove some unsightly warnings when using ggheatmap. Cheers

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/talgalili/dendextend/pull/94?email_source=notifications&email_token=AAHOJBQT32OM54E4WQ2YDZ3QLEXH5A5CNFSM4IYAPYY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7MJZ6Q#issuecomment-534289658, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHOJBV5QR6ZQNXIKK3DLGDQLEXH5ANCNFSM4IYAPYYQ .