talgalili / heatmaply

Interactive Heat Maps for R Using plotly
377 stars 73 forks source link

Plots not displayed in html from Rmd #259

Closed patzaw closed 3 years ago

patzaw commented 3 years ago

Hi

Since version 1.2.0, heatmaply plots are not displayed in html from Rmd

The vignette is an example as such: https://cran.r-project.org/web/packages/heatmaply/vignettes/heatmaply.html

Thank you

Patrice

alanocallaghan commented 3 years ago

Thanks for flagging this, that is indeed a bit of a problem

talgalili commented 3 years ago

Thanks! Ill check it out later today and fix.

T

On Mon, Feb 1, 2021, 13:00 Alanocallaghan notifications@github.com wrote:

Thanks for flagging this, that is indeed a bit of a problem

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/talgalili/heatmaply/issues/259#issuecomment-770769751, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHOJBXRP7CXYRE542RHUQLS42CUPANCNFSM4W4SDV3Q .

talgalili commented 3 years ago

Didn't get to it today, but will do it in the next 2 days.

T

On Mon, Feb 1, 2021, 13:52 Tal Galili tal.galili@gmail.com wrote:

Thanks! Ill check it out later today and fix.

T

On Mon, Feb 1, 2021, 13:00 Alanocallaghan notifications@github.com wrote:

Thanks for flagging this, that is indeed a bit of a problem

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/talgalili/heatmaply/issues/259#issuecomment-770769751, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHOJBXRP7CXYRE542RHUQLS42CUPANCNFSM4W4SDV3Q .

talgalili commented 3 years ago

Just pushed a new fix to github, version 1.2.1. Please LMK if this fixes the issue for you. (I'm going to push it to CRAN now)

patzaw commented 3 years ago

It looks OK with the report I've tested. Thank you for this quick fix

talgalili commented 3 years ago

Glad it worked :) I've sent heatmaply 1.2.1 to CRAN.

Cheers, T

On Tue, Feb 2, 2021 at 10:19 AM Patrice Godard notifications@github.com wrote:

It looks OK with the report I've tested. Thank you for this quick fix

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/talgalili/heatmaply/issues/259#issuecomment-771455565, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHOJBQZVENQFU5DQP2J33TS46YQVANCNFSM4W4SDV3Q .