talgalili / heatmaply

Interactive Heat Maps for R Using plotly

380 stars 73 forks source link

cellnote not working with ggheatmap #278

Open askhari139 opened 2 years ago

askhari139 commented 2 years ago

Describe the bug

Annotation using the cellnote option is not working. Below are the minimal examples that cause me the error. Am I missing something?

To Reproduce

ggheatmap(mtcars, draw_cellnote = T, cellnote_color = "white", cellnote_size = 20) ggheatmap(mtcars, cellnote = mtcars)

alanocallaghan commented 2 years ago

Nah this isn't currently supported because cellnote is added as a plotly layer

askhari139 commented 2 years ago

I see. Is there a way to support geom_text in the heatmap layers?

alanocallaghan commented 2 years ago

Not easily, but if you fancy making a pull request I can provide some guidance

alanocallaghan commented 2 years ago

Check out the cellnote branch if you like, but the functionality is worse on almost all counts than the existing version so I'm unlikely to merge it