search

talgautb / vexillum

Flags of the world on CSS - http://talgautb.github.io/vexillum/demo/
MIT License
9 stars 2 forks source link

Added flag for the Kingdom of the Netherlands #11

Closed stef-spee closed 2 years ago

stef-spee commented 2 years ago

I've added a flag for the Kingdom of the Netherlands. It's hard to find exact specifications for the colours and size, so I had to base upon Wikipedia: Flag of the Netherlands. I had issues with Gulp and NodeJS; "gulp primordials is not defined" which is 'fixed' by specifying 'npm-shrinkwrap.json' in the main folder.

talgautb commented 2 years ago

thank you for PR, but you should add flag's css to master branch

stef-spee commented 2 years ago

thank you for PR, but you should add flag's css to master branch

Ah, I got confused because the Readme file still talks about a Dev branch. I've updated the PR

stef-spee commented 2 years ago

I've had quite the time with removing the files, how does it look now?

talgautb commented 2 years ago

thank you for PR! lgfm

stef-spee commented 2 years ago

Thank you for accepting this PR, would you mind adding the hacktoberfest-accepted tag for me?