search

talhusain / SlothTorrent

8 stars 3 forks source link

Second pass for TorrentClient/test_get_message.py implementation #80

Closed squidmin closed 7 years ago

squidmin commented 7 years ago

It's likely we'll want some things changed soon, but hopefully these can serve as working test cases for a first pass.

squidmin commented 7 years ago

Changes have been made after seeing review by @talhusain.

Still unsure about some things. Especially some of the to_bytes() functions.

talhusain commented 7 years ago

Looks good to me now, but I was also confused on the "to_bytes" part, wasn't sure if I had the proper syntax. If it ran with no trouble then you're farther than I got. Thanks for picking up my slack, I got BSOD last night and just said f*** it all and went to bed lol

badstreff commented 7 years ago

Looks good, I'm fine with accepting it. Did you try running it? I'm curious to know the results. I know I had a few issues when running MessageQueue through testing.

squidmin commented 7 years ago

Output is currently:

$ python test_get_message.py
.....................................................
----------------------------------------------------------------------
Ran 53 tests in 0.004s

OK
badstreff commented 7 years ago

I'm fine with going ahead and accepting this PR whenever you are ready.