search

tali713 / esxml

An elisp library for working with xml, esxml and sxml.
58 stars 14 forks source link

Comment tags #30

Closed guraltsev closed 3 years ago

guraltsev commented 3 years ago

Both xml and html define comment tags to be of the form 

<!--this is a comment-->

libxml converts comment tags to tags called comment. Then, when exporting, these get rendered as 

<comment>this is a comment</comment>

I think this is a bug.

wasamasa commented 3 years ago

Yes it is. I'll have to look into how to tackle this properly. Probably in esxml--to-xml-recursive and maybe pp-esxml-to-xml.

tali713 commented 3 years ago

If the problem (as I understand it) is that libxml has an internal tag named comment, the simplest solution is indeed to update those two core functions to use pcase, rather than pcase-let, and special case that tag.

wasamasa commented 3 years ago

Good to see you're alive. I've updated a bit more than that and now the surrounding cond/if is replaced with pcase, too.

@guraltsev Could you please confirm it's fixed now?

guraltsev commented 3 years ago

Hello everyone. Thank you so much for the swift response. I confirm that it works perfectly now.