taligentx / dscKeybusInterface

An Arduino/esp8266/esp32 library to directly interface with DSC security systems.
GNU General Public License v3.0
504 stars 126 forks source link

PC5005 Keybus data capture - feedback requested #158

Open taligentx opened 4 years ago

taligentx commented 4 years ago

Per https://github.com/Dilbert66/esphome-dsckeybus/issues/2, there may be issues with the Keybus data coming from PC5005 panels - this issue is open to collect data to see if it's an isolated issue or common to all PC5005 panels.

If you have this panel, load the KeybusReader example sketch and capture the serial output while performing various activities: opening zones, arming the system, disarming the system, triggering an alarm, etc. Thanks!

Dilbert66 commented 4 years ago

Hi Nikhil, i have pull request that corrects this issue. The problem was that his panel sends spurious packets at odd times. The fix was to add a sort of debounce to the capture routine that selectively ignores the first few (adjustable number) commands before accepting as valid. Here's the link https://github.com/taligentx/dscKeybusInterface/pull/150. I have been running it on my system as well as is and is not detrimental to operations since the DSC sends all commands many times.

taligentx commented 4 years ago

Hi, yes I've been taking a look at the PR - in this case I'd like to see the data from KeybusReader from at least two or three different PC5005 panels as I'd like to see what's going on with all commands, especially commands with checksums to see if there are any CRC errors, etc popping up. Command '0x05' is a fundamental part of Keybus and it'd be interesting if all PC5005 panels shipped with firmware that screwed this up.

At this point I'd rather not change the command processing code based on a single report without much more data.

Dilbert66 commented 4 years ago

Understood. That was sure an oddball one with that panel. This might also be revision dependent so that he had a buggy version before DSC fixed it. Be nice to also know the firmware versions those panels had too.