search

taligentx / dscKeybusInterface

An Arduino/esp8266/esp32 library to directly interface with DSC security systems.
GNU General Public License v3.0
497 stars 125 forks source link

Added Github Action for Building Examples #209

Closed shafr closed 3 years ago

shafr commented 3 years ago

Hello @taligentx .

I've added 3 workflows, that would:

You would see if specific example had failed and you would be also able to add those badges on the README.MD page.

I hope they would help in future development / maintaining of your project.

Also you might want to look into https://github.com/Koenkk/zigbee2mqtt/tree/master/.github/ISSUE_TEMPLATE - it might help for future issues creation.

Regards, Dmitriy.

shafr commented 3 years ago

Also updated comments to Telegram example.

taligentx commented 3 years ago

I've added 3 workflows, that would:

install pio install dependencies compile examples. You would see if specific example had failed and you would be also able to add those badges on the README.MD page.

I hope they would help in future development / maintaining of your project.

Hi @shafr - thanks for the PR! This looks handy.

Also you might want to look into https://github.com/Koenkk/zigbee2mqtt/tree/master/.github/ISSUE_TEMPLATE - it might help for future issues creation.

I'll bump this up on the TODO list, it wasn't a priority until Github introduced Discussions, it'll be nice to keep Q&A and support questions out of Issues.

Also updated comments to Telegram example.

Thanks! However, the commit for the esp8266 example rearranges several functions, please revert this to the original order so only the updated comments are merged (as in the esp32 example).

Also, please re-base this to merge into develop, the master branch is only for releases. Thanks!

-Nikhil

shafr commented 3 years ago

Closing this one in favor of merge in dev