search

talios / clojure-maven-plugin

Apache Maven Mojo for compiling clojure scripts to class files
252 stars 74 forks source link

Do not swallow failure information #112

Closed agresch closed 5 years ago

agresch commented 5 years ago

Our clojure build failed with this failure when building on a new platform:

Caused by: org.apache.maven.plugin.MojoExecutionException: Clojure failed.

This is not very useful when debugging the real issue. This PR adds the failure information.

d2r commented 5 years ago

Related to #78.

We had to rebuild the plugin to find out that java was not on the PATH.

agresch commented 5 years ago

@talios - Please review.

talios commented 5 years ago

@agresch Will take a look tonight - sorry I didn't respond sooner, past few weeks have been a blur with work and music festival work.

agresch commented 5 years ago

Thanks!

talios commented 5 years ago

@agresch oddly I had to rework ( and ultimate, for now ) delete the two old autodoc IT tests as they were failing in order to build. Have reverted that commit on a feature branch and need to see if I can figure out whats up with that.

New release should be in central soon.

agresch commented 5 years ago

Thanks for getting this in!

d2r commented 5 years ago

Thanks for getting this in!

Agree, really appreciate looking at this.

talios commented 5 years ago

@d2r @agresch all good - pleased to see people actually still using the plugin :)