search

talios / clojure-maven-plugin

Apache Maven Mojo for compiling clojure scripts to class files
252 stars 74 forks source link

Support nrepl/nrepl #113

Closed arichiardi closed 5 years ago

arichiardi commented 5 years ago

Hi!

The new nrepl/nrepl server is now mature enough to be used in this plugin ;)

Basically just the entry point's namespace has changed (and the dependency declaration) so it should be a trivial change.

I was thinking though that probably it would be a good idea to create a new goal for it instead of changing the old behavior if we want to keep backward compatibility.

Any thought?

danielsz commented 5 years ago

The change is indeed trivial. The problem is that the test is breaking, and the reason for that is rather involved and related to how the integration tests are run. I can see that tools.nrepl is present on the classpath despite explicitly pulling nrepl/nrepl. I suspect a transitive dependency is pulling it in. I am currently trying to hunt it down. Wish me luck.

danielsz commented 5 years ago

OK, I found the problem. I'll do a PR as soon as I'm done.

arichiardi commented 5 years ago

Hey Daniel thanks for doing this and keep in mind I can help with the grunt work, now that you explained the problem I can apply the exclusions...

Oh ...if you found that's even better 😁

danielsz commented 5 years ago

Thank you, Andrea.

114

talios commented 5 years ago

@danielsz awesome! Will pull this in shortly ( probably tonight and release ).

danielsz commented 5 years ago

@talios Thank you! I love this project.

talios commented 5 years ago

Ahh - I see the commit message didn't mention the ticket so didn't auto-close. Manually doing so :)

talios commented 5 years ago

I updated the README to mention the new maven dependency/version - are all the arguments/system properties still valid?

danielsz commented 5 years ago

Yes, arguments/properties should be exactly as before, Thank you for updating the README with the new nREPL dependency/version. I forgot to do that myself. Sorry about that.

talios commented 5 years ago

...and released - should be in central within the hour.

arichiardi commented 5 years ago

Awesome I was exactly trying to fetch it :wink:

talios commented 5 years ago

@arichiardi if needed - you could probably resolve it from the oss.sonatype.org repositories directly - or just wait a bit longer :)