search

talios / clojure-maven-plugin

Apache Maven Mojo for compiling clojure scripts to class files
251 stars 74 forks source link

Update Marginalia Mojo to be 0.7 compatible. #49

Closed coltnz closed 12 years ago

coltnz commented 12 years ago

Needs to be integrated with patch-1

talios commented 12 years ago

Colin - this currently fails the integration tests:

Unable to resolve symbol: ensure-directory! in this context (marginalia2977730125939494240.clj:3)

Where does ensure-directory! come from? The IT test for marginalia currently runs using Clojure 1.2, was this introduced in a later version of Clojure?

coltnz commented 12 years ago

Nope ensure-directory! was in the mojo prior. All I did to the mojo was bind resources to "". The problem may be that marginalia 0.7 requires clojure 1.3. Is 1.2 support required any more?

talios commented 12 years ago

I've updated the use statement to pull back maginalia.core and the IT test now passes. Thanks for the patch.