search

talios / clojure-maven-plugin

Apache Maven Mojo for compiling clojure scripts to class files
252 stars 74 forks source link

Support m2e 1.1 #53

Open elzibubble opened 12 years ago

elzibubble commented 12 years ago

https://jira.codehaus.org/browse/MOJO-1785

When using m-clojure-p in Eclipse with m2e you get a "Plugin execution not covered..." message from m2e. This is because it doesn't know whether to run these goals during incremental compilation or not. To enable this m2e needs a little help. I submitted a little patch to the m-less-p which you can see at the link above. They had to do some extra work but the patch has now been integrated.

Please would you consider doing this for m-clojure-p? I hope m-less-p will serve as a useful reference.

talios commented 12 years ago

Sure - I'm taking a look at the linked MOJO ticket now and making similar changes in m-c-p, however as I don't use eclipse ( and actually, couldn't even figure out how to install m2e the last time I tried ) I'm not sure how I can test this.

talios commented 12 years ago

Out of curiosity - what is the desired change here? Are we wanting to attempt to add incremental compilation to c-m-p or just flag all goals in c-m-p as not running on runOnIncremental?

elzibubble commented 12 years ago

On 11 August 2012 08:59, Mark Derricutt notifications@github.com wrote:

Out of curiosity - what is the desired change here? Are we wanting to attempt to add incremental compilation to c-m-p or just flag all goals in c-m-p as not running on runOnIncremental?

Flag all goals ignored would be a good start.

Incremental compilation would be awesome though. I don't know much about what Clojure needs, what problems would only recompiling touched files give? You probably saw the LESS guys had to get a bit clever to deal with imports, would Clojure be able to cope with that by itself or would c-m-p need to figure that out for it and provide a "compilation bundle" without dangling refs?

elzibubble commented 12 years ago

Oops - and in answer to your first post, I can test it for you.

That said, it'll be easier for you if you can test locally. I fully accept Eclipse's update management is terribad but afaik m2e 1.1 is available through Eclipse Marketplace which makes it relatively easy. That's in the Help menu btw... not my fault.

cheenu2 commented 8 years ago

I am seeing this problem in current 1.8.1 (and m2e 1.6.2) as well. Was any change done for this? (codehaus isn't available anymore to see the submitted patch either)

talios commented 8 years ago

I've never written anything for m2e, and I don't use Eclipse. So no - no change was done for this.

Was that ticket moved over to mojohaus tho ( the new home of (most) of those plugins ).

c-m-p is basically in quiet maintenance mode, there is a release I was meaning to make the other day, I've just finished rebasing an old PR that never got applied, but have been sidetracked with work to release it - hopefully this weekend.