search

talios / clojure-maven-plugin

Apache Maven Mojo for compiling clojure scripts to class files
251 stars 74 forks source link

new REPL-y versions don't ignore unknown parameters as it used to and avoiding 'Argument too long' in Windows #58

Closed dlebrero closed 11 years ago

dlebrero commented 11 years ago

Removing "-r" from the command line when using REPL-y Creating a temporal empty jar with a manifest with all the entries of the classpath. Also fixed the iclojure/reply/jline detection in Windows Adding option to specify the command line to run in Windows when running the repl

Sorry for mixing 2 unrelated commits, but I created a pull request before the second commit and I didn't expect Github to mix both of them. I now realize that I should have created a branch for each change. Let me know if you want me to create 2 different pulls.

buildhive commented 11 years ago

Mark Derricutt » clojure-maven-plugin #14 SUCCESS This pull request looks good (what's this?)

buildhive commented 11 years ago

Mark Derricutt » clojure-maven-plugin #15 SUCCESS This pull request looks good (what's this?)

buildhive commented 11 years ago

Mark Derricutt » clojure-maven-plugin #16 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Mark Derricutt » clojure-maven-plugin #17 SUCCESS This pull request looks good (what's this?)

dlebrero commented 11 years ago

Hey Mark,

What do you need me to do to accept the pull request?

Thanks,

daniel

talios commented 11 years ago

Cheers! Sorry about being out of contact lately, several family medical issues have kept me occupied over the last week or so. Merged - and will look at a release soon.

Mark

dlebrero commented 11 years ago

Thanks a lot Mark!