search

talios / clojure-maven-plugin

Apache Maven Mojo for compiling clojure scripts to class files
252 stars 74 forks source link

Destroy subprocesses before exiting #59

Closed trptcolin closed 12 years ago

trptcolin commented 12 years ago

Reported in trptcolin/reply#90

When the main process doesn't take responsibility for shutting down subprocesses, those subprocesses may not have access to the terminal and other resources that the main process owns when they run their shutdown hooks.

In the case of REPLy, this means we don't get the opportunity to reset the stty hooks that jline2 installs.

Maybe there's a different / better way to accomplish this? But this does appear to do the trick for me locally, at least in the context of the proof-of-concept app that @JacekLach posted: https://github.com/JacekLach/reply-breakage

buildhive commented 12 years ago

Mark Derricutt » clojure-maven-plugin #20 SUCCESS This pull request looks good (what's this?)

talios commented 12 years ago

Cheers - will make another release of the plugin - 1.3.13 - which should be available in Maven Central later today.