search

talios / clojure-maven-plugin

Apache Maven Mojo for compiling clojure scripts to class files
252 stars 74 forks source link

Use COMPILE_PLUS_RUNTIME scope in ClojureRunMojo #69

Closed tobias closed 11 years ago

tobias commented 11 years ago

In the process of upgrading a mixed Java/Clojure project from 1.3.8 to 1.3.15, we ran into a problem caused by the requiresDependencyResolution for ClojureRunMojo being changed from COMPILE to RUNTIME. We have quite a few deps that are in the provided scope, and this change means we have to move them to the runtime scope for the clojure compile goal to see them. However, moving them to runtime prevents the java compile goal from seeing them.

I'm no maven expert, so I don't fully understand the implications of requiresDependencyResolution, but changing it to COMPILE_PLUS_RUNTIME allows us to build, and allows all of the plugin's tests to pass.

buildhive commented 11 years ago

Mark Derricutt » clojure-maven-plugin #35 FAILURE Looks like there's a problem with this pull request (what's this?)

tobias commented 11 years ago

Hrm, the tests passed before I merged in the 1.3.16 commits. I'll take a look.

tobias commented 11 years ago

Well, the test-resources test fails without my patch applied, so I'm off the hook :)

talios commented 11 years ago

Well that's odd that it fails for you as it passed when I released the plugin last night - bizarre.

talios commented 11 years ago

Pulled - and will check all the tests still pass and push out a .17 release :)

tobias commented 11 years ago

@talios great, thanks. The new release works great for me. And I saw #70, so we're all good :)