search

talios / clojure-maven-plugin

Apache Maven Mojo for compiling clojure scripts to class files
252 stars 74 forks source link

check file existence correctly if the script file is specified via absolute path #84

Closed bpodgursky closed 10 years ago

bpodgursky commented 10 years ago

plugin was failing to find the specified testScript on the filesystem when the path was absolute (ex, when we specified it in the pom as ${project.build.directory}/my_script.clj}), since it was trying to append this absolute path to the end of basedir. I think this should fix it.

buildhive commented 10 years ago

Mark Derricutt » clojure-maven-plugin #61 FAILURE Looks like there's a problem with this pull request (what's this?)

talios commented 10 years ago

Looks good, cheers - any chance of adding a simple IT test-project for this as well?

talios commented 10 years ago

Actually - I seem to get those buildhive IT failures on my local build of this PR as well...

bpodgursky commented 10 years ago

Yeah, I wasn't really sure what was up with those errors, couldn't really figure out what was wrong. I could take a look at adding a test project or something later.

bpodgursky commented 10 years ago

sorry about that, totally missed that this was all getting tested in integration-test rather than test phase. pushed the fix you suggested.

buildhive commented 10 years ago

Mark Derricutt » clojure-maven-plugin #62 SUCCESS This pull request looks good (what's this?)

talios commented 10 years ago

Cheers - doing a release of 1.3.23 now, this should hit maven central in a few hours.