search

talios / googleformatter-maven-plugin

Plugin for the Apache Maven build system to reformat source files.
Apache License 2.0
48 stars 11 forks source link

Support for JDK 17? #28

Open sureshg opened 1 year ago

sureshg commented 1 year ago

I am not sure whether this plugin is still maintained. If so, any plans to update the GJF version to latest which has support for the latest JDK versions. Thanks for making this plugin and allow us to make maxLineLength configurable.

dudeisbrendan03 commented 1 year ago 
> & mvn process-sources
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< com.group31.editor:pixel-editor >-------------------
[INFO] Building pixel-editor v0.1-CANARY
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- googleformatter-maven-plugin:1.7.3:format (reformat-sources) @ pixel-editor ---
[INFO] Found 37 uncompiled/modified files in C:\Users\Terri\source\repos\scc210-2223-grp-31\src\main\java to reformat.
[INFO] Found 1 uncompiled/modified files in C:\Users\Terri\source\repos\scc210-2223-grp-31\src\test\java to reformat.
[INFO] ------------------------------------------------------------------------
[INFO] Finished at: 2022-12-10T10:21:45Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.theoryinpractise:googleformatter-maven-plugin:1.7.3:format (reformat-sources) on project pixel-editor: 38:18: error: : expected -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

> java --version
openjdk 17.0.5 2022-10-18
OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8)
OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode)

>
dudeisbrendan03 commented 1 year ago

Appears to work with jdk17, getting a weird error with no clue how to fix it so I can't integrate it into Ci yet, but it doesn't look like anything too bad

tbw777 commented 1 year ago

@dudeisbrendan03 try to check: mvn -X option

talios commented 1 year ago

The only issue with updating it to the latest versions is we have to remove support for line length customization.

I'm not still not using >Java 8 (politics, infrastructure issues) so havn't updated this mojo, but on the project I am using 17+ - I'm now using the spotless plugin with either the google formatter, or the palantir formatter.