search

talis-fb / TReq

A CLI tool for effortless HTTP requests
GNU General Public License v3.0
55 stars 2 forks source link

Display response time #21

Closed SummerGram closed 8 months ago

SummerGram commented 8 months ago

Close #5

SummerGram commented 8 months ago

@talis-fb

Wait, I need to make some changes.

SummerGram commented 8 months ago

@talis-fb

Maybe I close this pull request and raise another one?

talis-fb commented 8 months ago

@talis-fb

Maybe I close this pull request and raise another one?

No, you can keep going on this, no problem.

talis-fb commented 8 months ago

As there are no many changes and a couple of commits I'm gonna squash when do the merge. Ok? But if your prefer I can do the normal merge without problem @SummerGram

SummerGram commented 8 months ago

@talis-fb

Sure!

I run cargo test and it works. But cargo test e2s is not working.

Btw, do we have some like discord or Zulip ?

talis-fb commented 8 months ago

@SummerGram reach me by telegram: https://talison.dev/. In this site I put a link for it

talis-fb commented 8 months ago

@talis-fb

Sure!

I run cargo test and it works. But cargo test e2s is not working.

Btw, do we have some like discord or Zulip ?

In the CONTRIBUTING.md I put some instructions for it. You run cargo test --features run_e2e_tests for run the e2e test plus anything else. But It's better you use the docker to run tests in a container and your current machine state does not affect tests.

docker compose -f tests/compose.yml build run_e2e 
docker compose -f tests/compose.yml run --rm run_e2e
SummerGram commented 8 months ago

@talis-fb

Even though I run cargo test --features run_e2e_tests in the develop branch, it still has failed tests.